Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable checkstyle failOnViolation #483

Closed
wants to merge 2 commits into from
Closed

Enable checkstyle failOnViolation #483

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abe0893
Enable checkstyle `failOnViolation`
timja Jun 5, 2022
9ffda47
Slightly better
timja Jun 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,12 +331,14 @@
<goals>
<goal>checkstyle</goal>
</goals>
<phase>verify</phase>
<phase>validate</phase>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure whether to keep here or not, but waiting for unit test suite for linting is not great

</execution>
</executions>
<configuration>
<linkXRef>false</linkXRef>
<failOnViolation>false</failOnViolation>
<violationSeverity>warning</violationSeverity>
Copy link
Member Author

@timja timja Jun 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be causing the build to fail locally at jenkinsci/prism-api-plugin@66dcb92 but it doesn't seem to be 😢

<failOnViolation>true</failOnViolation>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be the default and can be removed once working

<consoleOutput>true</consoleOutput>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes the errors go to build log

<configLocation>checkstyle-configuration.xml</configLocation>
<includeTestSourceDirectory>true</includeTestSourceDirectory>
<excludes>**/*Assert*.java,**/InjectedTest.java,**/Messages.java,**/*_jmh*</excludes>
Expand Down