Enable checkstyle failOnViolation
#483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something isn't right, I still can't get it to fail locally at commit jenkinsci/prism-api-plugin@66dcb92 |
timja
commented
Jun 5, 2022
| @@ -331,12 +331,14 @@ | |||
| <goals> | |||
| <goal>checkstyle</goal> | |||
| </goals> | |||
| <phase>verify</phase> | |||
| <phase>validate</phase> | |||
There was a problem hiding this comment.
not sure whether to keep here or not, but waiting for unit test suite for linting is not great
timja
commented
Jun 5, 2022
| <failOnViolation>false</failOnViolation> | ||
| <violationSeverity>warning</violationSeverity> | ||
| <failOnViolation>true</failOnViolation> | ||
| <consoleOutput>true</consoleOutput> |
There was a problem hiding this comment.
this makes the errors go to build log
timja
commented
Jun 5, 2022
| </execution> | ||
| </executions> | ||
| <configuration> | ||
| <linkXRef>false</linkXRef> | ||
| <failOnViolation>false</failOnViolation> | ||
| <violationSeverity>warning</violationSeverity> | ||
| <failOnViolation>true</failOnViolation> |
There was a problem hiding this comment.
this should be the default and can be removed once working
timja
commented
Jun 5, 2022
| </execution> | ||
| </executions> | ||
| <configuration> | ||
| <linkXRef>false</linkXRef> | ||
| <failOnViolation>false</failOnViolation> | ||
| <violationSeverity>warning</violationSeverity> |
There was a problem hiding this comment.
this should be causing the build to fail locally at jenkinsci/prism-api-plugin@66dcb92 but it doesn't seem to be 😢
|
Replaced by #907 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context jenkinsci/prism-api-plugin#41 (comment)