chore(pipeline) Limit Docker API rate limit when testing #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enkinsci#1634 (b1e9d05) Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
changed the title
timja
approved these changes
Jul 26, 2024
|
Fix seems to have failed, as https://ci.jenkins.io/job/Core/job/acceptance-test-harness/job/PR-1645/1/ failed with a rate limit error. |
Reopening jenkins-infra/helpdesk#4192 @basil I'm not sure about the error (I might be misusing the Test reports!) but I only see test errors reporting |
This was referenced Jul 31, 2024
dduportal
added a commit
to dduportal/acceptance-test-harness
that referenced
this pull request
Aug 6, 2024
…#1634 and jenkinsci#1640 Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
basil
pushed a commit
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixup of #1634 (b1e9d05)
This PR uses the DockerHub authentication in the proper location as pointed out by @basil in #1634 (review) (sorry for the noise)
The DockerHub login now happens at the beginning of each test:
Note: the long term solution would be to use a local Docker cache-through proxy as per jenkins-infra/helpdesk#4192 (comment).