Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Jenkinsfile) increase DockerHub rate limit with authentication #1634

Merged
merged 1 commit into from
Jul 25, 2024
Merged

chore(Jenkinsfile) increase DockerHub rate limit with authentication #1634

merged 1 commit into from
Jul 25, 2024

Conversation

dduportal
Copy link
Collaborator

@dduportal dduportal commented Jul 25, 2024 •
edited
Loading

@dduportal dduportal requested review from basil and timja July 25, 2024 05:36
@dduportal dduportal mentioned this pull request Jul 25, 2024
Closed
@timja timja merged commit b1e9d05 into master Jul 25, 2024
27 checks passed
@timja timja deleted the dduportal-patch-1 branch July 25, 2024 07:34
basil
basil reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this PR going to help at all? This logs into Docker during the "Record builds and sessions" stage, where Docker isn't needed; but fails to log into Docker during the test stage, where Docker is needed.

@dduportal
Copy link
Collaborator Author

How is this PR going to help at all? This logs into Docker during the "Record builds and sessions" stage, where Docker isn't needed; but fails to log into Docker during the test stage, where Docker is needed.

True, i messed up sorry. I will open another PR tomorrow (i am not sur how did I missed this)

dduportal added a commit to dduportal/acceptance-test-harness that referenced this pull request Jul 26, 2024
@dduportal
chore(pipeline) Limit Docker API rate limit when testing - fixup of j…
e3459a8 
…enkinsci#1634 (b1e9d05)

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal mentioned this pull request Jul 26, 2024
Merged
@dduportal
Copy link
Collaborator Author

Superseded (and fixed) by #1640

dduportal added a commit to dduportal/acceptance-test-harness that referenced this pull request Aug 6, 2024
@dduportal
chore(pipeline) stop using Docker login primitive - reverts jenkinsci…
c9dcb0b 
…#1634 and jenkinsci#1640

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
basil pushed a commit that referenced this pull request Aug 6, 2024
@dduportal
chore(pipeline) stop using Docker login primitive - reverts #1634 and #…
512b92b 
…1640 (#1662)

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basil basil basil left review comments

@timja timja timja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dduportal @basil @timja