Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sign to <activeProfiles> #292

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Conversation

basil
Copy link
Contributor

@basil basil commented Sep 21, 2022

Fixes a regression exposed by jenkinsci/pom#281 and jenkinsci/jenkins#6914. In order for release artifacts to be signed by maven-gpg-plugin and maven-jarsigner-plugin during the release:prepare goal, we rely on https://github.com/jenkinsci/jenkins/blob/d25704cfbc929bca3bd5e5675e1fe1aa1a58928c/pom.xml#L521-L540 and https://github.com/jenkinsci/jenkins/blob/d25704cfbc929bca3bd5e5675e1fe1aa1a58928c/war/pom.xml#L623-L648, activated by the release and sign profiles respectively. To activate these profiles during the release:prepare goal we currently rely on https://github.com/jenkinsci/jenkins/blob/d25704cfbc929bca3bd5e5675e1fe1aa1a58928c/pom.xml#L428-L429, which happens to expose a serious bug in recent versions of Maven Release Plugin as explained in jenkins-infra/helpdesk#3143 (comment). Fortunately for us, we can work around the problem by omitting any custom arguments from our Maven Release Plugin configuration as in #291 and jenkinsci/jenkins#7138, instead enabling these profiles via an <activeProfiles> setting in settings-release.xml as in this PR. Note that we cannot enable these profiles using releaseProfiles because that setting only applies to the release:stage and release:perform goals, not the release:prepare goal.

Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick investigation!

@NotMyFault NotMyFault merged commit 43a9681 into jenkins-infra:master Sep 21, 2022
@basil basil deleted the profiles branch September 21, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants