Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression exposed by jenkinsci/pom#281 and jenkinsci/jenkins#6914. In order for release artifacts to be signed by
maven-gpg-plugin
andmaven-jarsigner-plugin
during therelease:prepare
goal, we rely on https://github.com/jenkinsci/jenkins/blob/d25704cfbc929bca3bd5e5675e1fe1aa1a58928c/pom.xml#L521-L540 and https://github.com/jenkinsci/jenkins/blob/d25704cfbc929bca3bd5e5675e1fe1aa1a58928c/war/pom.xml#L623-L648, activated by therelease
andsign
profiles respectively. To activate these profiles during therelease:prepare
goal we currently rely on https://github.com/jenkinsci/jenkins/blob/d25704cfbc929bca3bd5e5675e1fe1aa1a58928c/pom.xml#L428-L429, which happens to expose a serious bug in recent versions of Maven Release Plugin as explained in jenkins-infra/helpdesk#3143 (comment). Fortunately for us, we can work around the problem by omitting any custom arguments from our Maven Release Plugin configuration as in #291 and jenkinsci/jenkins#7138, instead enabling these profiles via an<activeProfiles>
setting insettings-release.xml
as in this PR. Note that we cannot enable these profiles usingreleaseProfiles
because that setting only applies to therelease:stage
andrelease:perform
goals, not therelease:prepare
goal.