Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead arguments code #291

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Conversation

basil
Copy link
Contributor

@basil basil commented Sep 21, 2022

The release build sets -Darguments in various places in a futile attempt to reduce log spam, futile because that setting is ignored due to the presence of https://github.com/jenkinsci/jenkins/blob/d25704cfbc929bca3bd5e5675e1fe1aa1a58928c/pom.xml#L429, as one can see by looking at the actual console output and seeing the log spam. And furthermore, the presence of custom arguments anywhere (either via -Darguments in the top-level Maven invocation or in the maven-release-plugin configuration in pom.xml) seems to break the release:stage goal in Maven Release Plugin 3.x as described in jenkins-infra/helpdesk#3143 (comment), so removing this dead code takes us one step closer toward working around the problem (the other step being removing the custom configuration in pom.xml).

Copy link
Contributor

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since JDK 11 the log output is a joke anyway.

@NotMyFault
Copy link
Member

👏🏻

@NotMyFault NotMyFault merged commit 4a61824 into jenkins-infra:master Sep 21, 2022
@basil basil deleted the arguments branch September 21, 2022 20:06
@basil
Copy link
Contributor Author

basil commented Sep 21, 2022

Since JDK 11 the log output is a joke anyway.

I do not see how JDK 11 would have changed anything. Seems like this has always been dead code since the day it was written, given how core's pom.xml had an arguments directive that superseded whatever was passed in here via -Darguments. MRELEASE-1048 was fixed, so presumably once the Maven folks fix the arguments issue, we could then pass -Darguments='--no-transfer-progress' to avoid the log spam (now that we eliminated any custom arguments from core's pom.xml).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants