NEEDS TESTING: Added lookupDelay with ASUS configuration #2124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code changes on their own in that commit generate 143 errors (due to not propagating the lookupDelay through everywhere VSCode thinks it should go. With that said, I tried hard coding a 3 second and a 10 second delay in the file with if (store.lookupDelay) { ... }, and even with a 10 second delay I am still getting false hits on the Asus store |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Asus store uses an anti-bot feature to show "add to cart" briefly before changing to an out of stock button. This fix circumvents that by delaying a configured amount of time per store (when specified). This is an untested PR, but can serve as a foundation for a fix if it does not function out of the box.
Fixes: #1901
Testing
Run app, ensure calls to asus.com do not report false positives.