Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asus store reports in stock cards but no stock is shown in browser. #1901

Closed
LFAdams opened this issue Feb 6, 2021 · 9 comments · Fixed by #2155
Closed

Asus store reports in stock cards but no stock is shown in browser. #1901

LFAdams opened this issue Feb 6, 2021 · 9 comments · Fixed by #2155

Comments

@LFAdams
Copy link

LFAdams commented Feb 6, 2021

Expected Behavior

The program should not report in-stock from the asus store when none are available.

Current Behavior

the program constantly reports in-stock cards from the asus store, including pictures showing an add to cart button. When I click the link to go to the site there are none available. This happens every couple of minutes per card such that I get a constant stream of in stock notifications for asus, so i know im not just missing the stock by being slow.

Steps to Reproduce

Install streetmerchant via dock container on unraid
include asus in STORES variable
Set notifications to use a gmail account
Receive endless in stock notifications for asus cards.

Environment

  • OS:
    Unraid

Logs

@bakamano
Copy link

bakamano commented Feb 7, 2021

also running into same issue

@zkghost
Copy link

zkghost commented Feb 8, 2021

the pages show "add to cart" for a moment and then it reverts to "unavailable" or something, it's probably a cheap anti bot measure. Or rather makes the bot too spammy. i'd have to look at the code to see how easy this would be, but we need to essentially sleep for a few seconds and then check the state

@PacketShepard
Copy link

Same issue here. I've disabled Asus stores for a few weeks now.

@MuhsinunC
Copy link

Yup same issue here. @zkghost yes that is the issue. Any updates?

@Fmstrat
Copy link
Contributor

Fmstrat commented Mar 11, 2021

Checking on an update as well, running into this, too.

@Fmstrat
Copy link
Contributor

Fmstrat commented Mar 11, 2021

I think we need a delay option in the store ts that pulls through to lookup.ts. This way the anti-bot measure is thwarted. I thought at first this had something to do with the coming soon language, but that doesn't seem to be the case.

@Fmstrat
Copy link
Contributor

Fmstrat commented Mar 11, 2021

Anyone here willing to test this out, please let me know how it worked.

@Fmstrat
Copy link
Contributor

Fmstrat commented Mar 16, 2021

So this was tested and did not work. I'm wondering if somehow it is because the Asus config is out date. I'm seeing a number of cards who's model numbers have changed. I'm working through a PR on that and will see if it has any impact.

@Fmstrat
Copy link
Contributor

Fmstrat commented Mar 16, 2021

Well, that seems to be it. The above change worked for me (for 3080 searches). The 3060s are not up on their site at the moment, so ymmv there.

@jef jef closed this as completed in #2155 Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants