Issues Fixed: #100, #101, #102 #103
Conversation
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
- Coverage 15.27% 15.12% -0.16%
==========================================
Files 95 95
Lines 733 734 +1
Branches 42 43 +1
==========================================
- Hits 112 111 -1
- Misses 594 596 +2
Partials 27 27
Continue to review full report at Codecov.
|
package.json
Outdated
| @@ -16,7 +16,8 @@ | |||
| "test:infrastructure": "jest test/tests/infrastructure", | |||
| "test:services": "jest test/tests/services", | |||
| "test": "jest && codecov", | |||
| "prepublishOnly": "npm run build" | |||
| "prepublishOnly": "npm run build", | |||
There was a problem hiding this comment.
Should prepublish even be kept if prepare is present
There was a problem hiding this comment.
scratch that, based on what i read, prepare will run on npm install and npm publish, but this doesnt make much sense if the build folder already exists in npm no? When a user of the library does npm install it try and build the solution again. Why should that be done?
There was a problem hiding this comment.
Yes, you are right.
I added the "prepare" stage only to install the library from my repository, and test it in my project.
If you merge in master, we can also remove this stage, because during the publishing on npm, the build stage will be done.
# Conflicts: # src/infrastructure/RequestHelper.js
|
I've done the changes 👍 |
|
I'll merge today! Just need to fix up the limiting |
Hi,
I fixed the issues: #100, #101, #102.
If you agree, you can merge in master branch.
Thanks,
Greetings