Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show functions not working #100

Closed
giuseppeangri opened this issue Jun 5, 2018 · 4 comments
Closed

Show functions not working #100

giuseppeangri opened this issue Jun 5, 2018 · 4 comments

Comments

@giuseppeangri
Copy link
Contributor

giuseppeangri commented Jun 5, 2018

Hi,
I tried to use the show functions (both in Users and Projects), but it doesn't work.

I use the functions in this way:

gitlab.Users.show(userId)
    .then(
        (gitlabResponse) => {
            console.log(gitlabResponse);
        },
        (gitlabError) => {
            console.log(gitlabError);
        }
    );

I receive this error:

TypeError: response.body is not iterable
    at .../node_modules/gitlab/dist/es5/infrastructure/RequestHelper.js:92:31
    at Generator.next (<anonymous>)
    at step (.../node_modules/@babel/runtime/helpers/asyncToGenerator.js:12:30)
    at _next (.../node_modules/@babel/runtime/helpers/asyncToGenerator.js:27:9)
    at <anonymous>

Furthermore I can confirm that the show functions worked fine with the old version of library:

"node-gitlab-api": "^3.0.2"

Thanks for this library,
Greetings!

giuseppeangri added a commit to giuseppeangri/node-gitlab that referenced this issue Jun 5, 2018
@jdalrymple
Copy link
Owner

Not sure how I missed this obvious error when I was testing smh. Nice catch

@giuseppeangri
Copy link
Contributor Author

I already fixed this issue and also the other two issues that I detected (#101, #102).
I send you all in a pull request.
Let me know if there are question! 😃

Greetings!

@jdalrymple
Copy link
Owner

Yup I saw! I asked a question in the pr

@jdalrymple
Copy link
Owner

Going to push this in the release today! Just need to fix up the limiting :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants