Return to a one-token-per-channel model #946
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This essentially reverts #850 (though a direct revert wasn't practical given the volume of changes between #850 and the present). We've observed in #931 that a shared token model can lead to a situation where:
In that case, from the server's perspective, channel B has used two different authentication tokens in rapid succession, leading to a
TooManyProviderTokenUpdates
rejection.The hope is that this fixes #931. At the same time, this will need some testing because this is reverting to exactly(?) the same state that prompted us to try #850 in the first place.