Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share authentication tokens between connections within a client #850

Merged
merged 3 commits into from
Mar 10, 2021

Conversation

jchambers
Copy link
Owner

In an effort to fix #811, this introduces an AuthenticationTokenProvider that allows multiple connections within an ApnsClient instance to share a single authentication token, reducing the number of token rotations over time.

@jchambers
Copy link
Owner Author

jchambers commented Feb 21, 2021

One problem I spotted in review: TokenAuthenticationApnsClientHandler needs a way to report to the provider that it thinks the token has expired if we get a TooManyProviderTokenUpdates (edit: I meant ExpiredProviderToken; pardon the confusion) response from the server.

@jchambers
Copy link
Owner Author

TokenAuthenticationApnsClientHandler needs a way to report to the provider that it thinks the token has expired…

This is done.

@jchambers jchambers force-pushed the shared_auth_token_provider branch from cc0cbaf to 0f84977 Compare March 10, 2021 19:25
Base automatically changed from simplify_auth_exceptions to master March 10, 2021 19:27
@jchambers jchambers added this to the v0.15.0 milestone Mar 10, 2021
@jchambers jchambers force-pushed the shared_auth_token_provider branch from 0f84977 to 358d254 Compare March 10, 2021 19:29
@jchambers jchambers merged commit e67df92 into master Mar 10, 2021
@jchambers jchambers deleted the shared_auth_token_provider branch March 10, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TooManyProviderTokenUpdates issue on v0.14.1
1 participant