Fix _NOEXCEPT not available in VS2017 15.8. Use noexcept for VS2015+ #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this breaks the linux build: https://travis-ci.org/jbeder/yaml-cpp/jobs/392914510 You still need to preserve the behavior if _MSC_VER is not defined. |
alexkaratarakis
force-pushed
the
vs15.8_NOEXCEPT
branch
from
9311f43
to
e7e7b6f
Compare
|
Fixed! |
|
Just encountered this issue after upgrading Visual Studio. Please do merge! |
htuch
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Aug 16, 2018
Version 0.6.2 of yaml-cpp does not build when using Visual Studio 15.8, for context see: jbeder/yaml-cpp#597 Updating to this commit fixes the issue. Risk Level: Low Testing: bazel test //test/... on Linux. Signed-off-by: Sam Smith <sesmith177@gmail.com>
Closed
bryanwweber
added a commit
to Cantera/cantera
that referenced
this pull request
Jun 27, 2019
For VS2017, we need fixes from jbeder/yaml-cpp#597 to compile the submodule
speth
pushed a commit
to Cantera/cantera
that referenced
this pull request
Jun 27, 2019
For VS2017, we need fixes from jbeder/yaml-cpp#597 to compile the submodule
|
@jbeder: Any chance a new release (0.6.3 maybe) including this could be cut soon? |
5 tasks
decaluwe
pushed a commit
to CSM-Offenburg/cantera
that referenced
this pull request
Oct 8, 2019
For VS2017, we need fixes from jbeder/yaml-cpp#597 to compile the submodule
BillyDonahue
pushed a commit
to mongodb-forks/yaml-cpp
that referenced
this pull request
May 24, 2020
…beder#597) (cherry picked from commit 0f9a586)
srikanthallu
pushed a commit
to srikanthallu/cantera
that referenced
this pull request
Sep 17, 2020
For VS2017, we need fixes from jbeder/yaml-cpp#597 to compile the submodule
olivier-stasse
added a commit
to olivier-stasse/yaml_cpp_vendor
that referenced
this pull request
Dec 16, 2020
This release is suppose to fix the two problems specified previously in the comment: jbeder/yaml-cpp#538 jbeder/yaml-cpp#597 Tested (and needed) on macOS Catalina.
olivier-stasse
added a commit
to olivier-stasse/yaml_cpp_vendor
that referenced
this pull request
Dec 16, 2020
This release is suppose to fix the two problems specified previously in the comment: jbeder/yaml-cpp#538 jbeder/yaml-cpp#597 Tested (and needed) on macOS Catalina. Signed-off-by: O. Stasse <ostasse@laas.fr>
olivier-stasse
added a commit
to olivier-stasse/yaml_cpp_vendor
that referenced
this pull request
Dec 16, 2020
This release is suppose to fix the two problems specified previously in the comment: jbeder/yaml-cpp#538 jbeder/yaml-cpp#597 Tested (and needed) on macOS Catalina. Signed-off-by: Olivier Stasse <ostasse@laas.fr>
olivier-stasse
added a commit
to olivier-stasse/yaml_cpp_vendor
that referenced
this pull request
Dec 17, 2020
This release is suppose to fix the two problems specified previously in the comment: jbeder/yaml-cpp#538 jbeder/yaml-cpp#597 Tested (and needed) on macOS Catalina. Signed-off-by: Olivier Stasse <ostasse@laas.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual Studio 2017 15.8 no longer defines _NOEXCEPT, leading to several of these:
error C3646: '_NOEXCEPT': unknown override specifiernoexceptis defined in VS2015+ (reference: link)This PR changes the YAML_CPP_NOEXCEPT to be defined as
noexceptfor VS2015+.We used the same patch in vcpkg to resolve the issue: link
edit:
_MSC_VERvalues: link