TemplateEngines.tryLoadEngines should catch all throwables related to class loading issues

[kwin]

Currently in

jbake/jbake-core/src/main/java/org/jbake/template/TemplateEngines.java

Line 80 in aebf496

} catch (Exception e) {

only Exceptions are being caught, but e.g. a java.lang.NoClassDefFoundError is not an Exception but only derived from a Throwable. Since all engines are IMHO optional even a NoClassDefFoundError should be caught and logged. For a concrete use cases where this is an issue look at jbake-org/jbake-maven-plugin#17 (comment).

At the same time it would be reasonable to lower the log level to WARN in (

jbake/jbake-core/src/main/java/org/jbake/template/TemplateEngines.java

Line 81 in aebf496

LOGGER.error("unable to load engine", e);

) as it is perfectly fine if not all template engines are loaded in case they are not actually used.

[kwin]

This is a regression caused by 9a0727a. So it only happens since v 2.6.2.

[kwin]

@jonbullock Is it possible to include the linked PR in the upcoming 2.6.4 release? IMHO this is a pretty nasty regression.

[jonbullock]

Yeah I'll merge that in now.