-
Notifications
You must be signed in to change notification settings - Fork 15
Adjustments to make it compatible with JBake 2.6.2 #17
Adjustments to make it compatible with JBake 2.6.2 #17
Conversation
Unfortunately that fix isn't enough, whenever I try to execute the Maven Goal
The reason is that the Jade Engine is referenced in https://github.com/jbake-org/jbake/blob/master/jbake-core/src/main/resources/META-INF/org.jbake.parser.TemplateEngines.properties but the class is no contained on the classpath. Actually JBake Core should not fail in that case, to be able to prevent to load dependencies for actually not used classes (like Jade in my case). That was not an issue with JBake 2.6.1 (that silently ignored not available template engines). |
Did you figure out the root cause of the class not found issue in relation to Jade? |
Oh and thanks for taking the time to raise this PR 👍 |
Well the exception is thrown from https://github.com/jbake-org/jbake/blob/4f3a18ae5a42686ffa761cef2e604f0a9f0f2000/jbake-core/src/main/java/org/jbake/template/TemplateEngines.java#L78. as the constructor cannot be executed due to missing classes. It is not caught by the surrounding catch block (https://github.com/jbake-org/jbake/blob/4f3a18ae5a42686ffa761cef2e604f0a9f0f2000/jbake-core/src/main/java/org/jbake/template/TemplateEngines.java#L81), because the Most probably switching from I logged the issue jbake-org/jbake#567 for that. |
Excellent work @kwin 👍 |
This closes #16