Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check format using ruff #1457

Merged
merged 7 commits into from
Aug 15, 2024
Merged

check format using ruff #1457

merged 7 commits into from
Aug 15, 2024

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Aug 15, 2024

Description of the Change

Format check using Ruff in separate job, because it doesn't depend on neither Python nor Django versions. I'm planning to replace isort and flake8 with Ruff in coming days.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@n2ygk n2ygk added this to the 3.0.0 milestone Aug 15, 2024
@n2ygk
Copy link
Member

n2ygk commented Aug 15, 2024

Needs to rebase due to merging #1454

@dulmandakh
Copy link
Contributor Author

Needs to rebase due to merging #1454

@n2ygk done

Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@n2ygk n2ygk merged commit 3e0329d into jazzband:master Aug 15, 2024
20 checks passed
@dulmandakh dulmandakh deleted the ruff-format branch August 15, 2024 14:26
@dulmandakh dulmandakh mentioned this pull request Aug 15, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants