Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat with LoginRequiredMiddleware middleware #1454

Merged
merged 16 commits into from
Aug 15, 2024

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Aug 14, 2024

Description of the Change

Django 5.1 introduced LoginRequiredMiddleware to allow authentication across the site, and this PR adds compatibility with it using login_not_required decorator.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@dulmandakh dulmandakh changed the title compat with LoginRequiredMiddleware and login_not_required compat with LoginRequiredMiddleware middleware Aug 14, 2024
@n2ygk n2ygk modified the milestones: Future, 3.0.0 Aug 14, 2024
@n2ygk
Copy link
Member

n2ygk commented Aug 14, 2024

please request a review when ready

@dulmandakh
Copy link
Contributor Author

dulmandakh commented Aug 15, 2024

@n2ygk changed tests. Please don't pay attention to CI configuration changes, I'll rebase once #1455 merged.

@n2ygk n2ygk self-requested a review August 15, 2024 13:04
@n2ygk
Copy link
Member

n2ygk commented Aug 15, 2024

@n2ygk changed tests. Please don't pay attention to CI configuration changes, I'll rebase once #1455 merged.

OK #1455 merged to please rebase.

@dulmandakh
Copy link
Contributor Author

@n2ygk done, all tests are passing 😉

Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@n2ygk n2ygk merged commit 1dcef1b into jazzband:master Aug 15, 2024
19 checks passed
@dulmandakh dulmandakh deleted the login_not_required branch August 15, 2024 14:15
@n2ygk n2ygk mentioned this pull request Aug 15, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants