Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial component tests for Credit #299

Merged
merged 1 commit into from Oct 3, 2020
Merged

Add initial component tests for Credit #299

merged 1 commit into from Oct 3, 2020

Conversation

ghost
Copy link

@ghost ghost commented Sep 29, 2020

Adding initial component tests for Credit.vue that ensures the following:

  • Text contains Photo by {name}
  • Link to photographer's Unsplash page

Referencing test issue #124

@jayehernandez
Copy link
Owner

Lgtm! Thanks for creating this test!

@all-contributors please add @justinhhorner for testing

@allcontributors
Copy link
Contributor

@jayehernandez

I've put up a pull request to add @justinhhorner! 🎉

@jayehernandez jayehernandez merged commit 58857f3 into jayehernandez:master Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant