Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧪 Add Unit Test to Files with Jest #124

Open
jayehernandez opened this issue Jun 2, 2020 · 5 comments · Fixed by #160 or #221
Open

🧪 Add Unit Test to Files with Jest #124

jayehernandez opened this issue Jun 2, 2020 · 5 comments · Fixed by #160 or #221
Labels
help wanted Extra attention is needed testing

Comments

@jayehernandez
Copy link
Owner

jayehernandez commented Jun 2, 2020 •
edited
Loading

We've recently added unit testing using Jest c/o @tbarland77 (thank you!).

You can choose to add an issue to either the server files or client files.

No need to wait for you to be assigned to this issue, just reference it when you make a PR. Please make sure that the file you are about to add a test to does not have a pending PR or existing test in the master branch.

Guidelines for testing to follow! Check out #125 for progress on this part.
@jayehernandez jayehernandez added testing help wanted Extra attention is needed labels Jun 2, 2020
@tbarland77 tbarland77 mentioned this issue Jun 6, 2020
Merged
@jayehernandez jayehernandez linked a pull request Jun 7, 2020 that will close this issue
Add a few tests for letra.js and options button #160
Merged
@AragonCodes AragonCodes mentioned this issue Jun 19, 2020
Merged
@tbarland77 tbarland77 mentioned this issue Jun 24, 2020
Merged
@nicolas-alv3
Copy link
Contributor

Hi!, Do you need more test? (In adittion to the ones that @tbarland77 did)

@jayehernandez
Copy link
Owner Author

Hi!, Do you need more test? (In adittion to the ones that @tbarland77 did)

Hey @nicolas-alv3, yes sure! You can work on the files @tbarland77 did not cover in his recent PR :)

@jayehernandez jayehernandez linked a pull request Jun 26, 2020 that will close this issue
Feature/letra 95 - Add remaining tests for component buttons, add router tests, and add store tests #221
Merged
@king-11
Copy link
Contributor

king-11 commented Sep 21, 2020

@jayehernandez are there any more tests that needs to be added to the server or client I would love to contribute :)

@ghost ghost mentioned this issue Sep 29, 2020
Merged
@hjades hjades mentioned this issue Oct 3, 2020
Merged
@jayehernandez jayehernandez mentioned this issue Oct 3, 2020
Merged
@hjades hjades mentioned this issue Oct 4, 2020
Merged
@PulkitAgg PulkitAgg mentioned this issue Oct 5, 2020
Merged
@bobsany16
Copy link
Contributor

bobsany16 commented Oct 7, 2020 •
edited
Loading

@jayehernandez I'm working on adding test for Time view. Currently at 11% coverage. Having some trouble with testing the getNow() and its content.

@bobsany16 bobsany16 mentioned this issue Oct 10, 2020
Merged
@jayehernandez
Copy link
Owner Author

@bobsany16 cool, will comment on your PR!

@bobsany16 bobsany16 mentioned this issue Oct 12, 2020
Merged
@j4ckofalltrades j4ckofalltrades mentioned this issue Oct 15, 2020
Merged
@bobsany16 bobsany16 mentioned this issue Oct 17, 2020
Closed
This was referenced Oct 27, 2020
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed testing
Projects
None yet
Milestone
No milestone
4 participants
@jayehernandez @nicolas-alv3 @bobsany16 @king-11