Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post highlighter tweaks #5663

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Post highlighter tweaks #5663

merged 3 commits into from
Sep 17, 2024

Conversation

shun2wang
Copy link
Contributor

No description provided.

@JorisGoosen
Copy link
Contributor

Why no highlight in the output?

It also prints what users entered, could be nice to see highlighting there no?
(I mean, I doubted if I should add it but I figured it was nicer with than without but I can def be convinced)

And the change for the JS: I have no idea what you changed there or why and cnnot guess from the code alone. Could you explain for my benefit? ^^

@shun2wang
Copy link
Contributor Author

shun2wang commented Sep 16, 2024 •
edited
Loading

  1. for the R command output window will print dataframe, tables, error code...which should not be "highlight" cause complex type. we should only highlight r code in "input" window.
    image
    A bit strange, but no big deal...I'm not very persistent in my opinion haha

  2. that was mistake I introduced from dependencies: upgrade marked.js to fix markdown render #5635, this was a js module but we should use js script directly, a error you can see in the devtools😉

@shun2wang
Copy link
Contributor Author

OK, as we talked in mattermost, let's add it back.

@JorisGoosen JorisGoosen merged commit d79cebc into jasp-stats:development Sep 17, 2024
@shun2wang shun2wang deleted the postHighlighterFixes branch September 17, 2024 09:09
JorisGoosen pushed a commit that referenced this pull request Sep 30, 2024
@shun2wang @JorisGoosen
Post highlighter tweaks (#5663)
d26c0d4 
* dont use modules for ext

* dont highlight R commander output window

* add highlighter back to R command output window
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorisGoosen JorisGoosen JorisGoosen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shun2wang @JorisGoosen