Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: upgrade marked.js to fix markdown render #5635

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

shun2wang
Copy link
Contributor

Fix: jasp-stats/jasp-issues#2847

It's a bug of marked.js and was fixed from v5.0.4 so let's just upgrade it.

@boutinb
Copy link
Contributor

boutinb commented Aug 27, 2024

This does not fix the issue, but it is still a good thing to update the marked.js

@boutinb boutinb merged commit e5877e7 into jasp-stats:development Aug 27, 2024
@shun2wang
Copy link
Contributor Author

shun2wang commented Aug 27, 2024

I can reproduce it on marked.js 5.0.3 but not 5.0.4 or later on their demo page.

@shun2wang shun2wang deleted the fixMarkdownRender branch August 27, 2024 12:39
@shun2wang
Copy link
Contributor Author

shun2wang commented Aug 27, 2024

image
image

Yes the origin markdown code in our repo has a space not a newline(see:https://github.com/jasp-stats/jaspRegression/blob/92e7db0c5e6a9e1c5ea50a7fc854305b2c75ab9a/inst/help/RegressionLogistic.md?plain=1#L3 ) but that's about markedjs/marked@efc40df fix from markdown files was not robust so I fix it by Js parser side.

Maybe you might be caught by the build cache I guess, because our build sometimes doesn't update the js code immediately, you can check your Resources/Help/marked.js folder to confirm this:-)

@boutinb
Copy link
Contributor

boutinb commented Aug 27, 2024

Hmm, strange. I could fix the issue by removing some spaces jasp-stats/jaspRegression@f8484ee

@shun2wang
Copy link
Contributor Author

shun2wang commented Aug 27, 2024

which version of marked.js in your built path 'Resources/Help/marked.js', anyway both fix are OK but your build dir may not updated I guess😀

JorisGoosen pushed a commit that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Strange formatting of text in the help box in the logistic regression module
2 participants