Use _.create in extend #3553
Merged
Use _.create in extend #3553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it worth breaking backwards compatibility so soon for this? Not worth waiting until |
|
Just raising an issue, can sit on it. It shouldn't break backwards compat unless people are relying on old versions of underscore |
|
The extend vs assign (in create) is a midly breaking change. I think the common case, though, is simple objects. |
3 tasks
| // if supplied. | ||
| if (protoProps) _.extend(child.prototype, protoProps); | ||
| // `parent`'s constructor function and add the prototype properties. | ||
| child.prototype = _.create(parent.prototype, protoProps); |
There was a problem hiding this comment.
You'll also need to set child.prototype.constructor = child.
|
Ping @megawac, want to rebase and add in the |
megawac
force-pushed
the
extend-create
branch
from
9804472 to
3c6fabb
Compare
|
Right, done |
|
LGTM. |
|
April's long enough. Let's do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned here jashkenas/underscore#2074