v1.2.4

[jridgewell]

Features

• Use _.create in .extend Use _.create in extend #3553
• Add #findIndex and #findLastIndex to Collection Add findIndex and findLastIndex underscore methods to Collection. #3811

Bug Fixes

• #_removeModels model still in collection regression Fix _removeModels regression #3803
• #set model id regression Fix 1.2.2 Model#id regression #3833
• #remove returning false regression Always return removed array from #_removeModels #3837
• #reduce and friends regression Add reduce to deopted methods #3820

Maybe

• Deopt Underscore methods containing arguments Deopt Underscore methods that use arguments #3840
• Add #preinitialize Add a preinitialize method to allow for true instance properties and ES6 classes #3827
• Add update event feedback adding feedback to update event of collection #3711
• Object.prototype conflicts with _.defaults Avoid Object.prototype collisions with defaults #3843

/cc @paulfalgout. 😄

[akre54]

Well Jeremy is currently taking on the Americas on his bike, so I believe the decision falls to @braddunbar on how and when to cut a release.

#3827 and #3820 #3840 are pretty ugly hacks. Are you sure they're necessary?

[jridgewell]

I scaled #3820 back to just deopting #reduce, not the arguments check that's now in #3840. The arguments check isn't necessary.

---

As for #3827, I think it should go out with this release, since I don't imagine any more v1 releases (I'd rather start merging v2 PRs). Non-breaking, generic, and people can choose to incorporate ES6 without redoing the entire app for v2.

I think it's pretty good solution... Do you have a particular objection to it?

[akre54]

The arguments check isn't necessary.

Right, I was referring to pre-split. I'm still not a fan of #3840.

I'd rather start merging v2 PRs

What've you got in mind for v2? A complete overhaul? Something more gradual?

I think it's pretty good solution... Do you have a particular objection to it?

(Responding there for clarity)

[jridgewell]

Adding #3842 as a needed bugfix.

[paulfalgout]

updates?

[jdalton]

For the remaining new features of

Add #preinitialize #3827
Add update event feedback #3711

I think they can be cut unless there are PRs ready to merge.
It looks like there's a PR for #3711 but it has fallen idle with merge conflicts.

[jridgewell]

Agreed, I think this is ready to go.

[megawac]

Anyone want to draft up a pull request with changelog/documentation updates?

[jdalton]

Ping? @braddunbar

If not I'll try to get a PR out tonight.

[jridgewell]

It's usually @paulfalgout. 😄

[jdalton]

First one with the PR wins!

[paulfalgout]

ha! Yeah @jdalton take it if you're up for it. I am a bit snowed under this week. If you don't get around to it, I'll jump in later.

[jdalton]

Draft changelog at #3921.

[jridgewell]

Closing with #3921.