-
-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bukuserver] Favicon #632
[bukuserver] Favicon #632
Conversation
4f7d4b2
to
62254e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this one too
buku/bukuserver/templates/bukuserver/base.html
Lines 5 to 8 in 3e407bf
{% block styles %} | |
{{super()}} | |
<link rel="icon" href="data:;base64,iVBORw0KGgo="> | |
{% endblock %} |
any reason not to put it on main .gitignore? |
This file is no longer used in the first place; it'd make more sense to remove it entirely (along with other dead code). |
|
…Speaking of running tests locally – one of Not sure why this happens (perhaps it's related to me using a VPN for internet access?), but it certainly results in guaranteed fails every time I run unit tests locally. (…Does it really count as a unit test if the network requests are actually being sent? Normally you'd expect the requests themselves to be mocked or at least extracted to external functionality, in part to avoid such factors from affecting the outcome – after all, I doubt that the goal is to test specifically whether the code can communicate with Google servers.) |
9f34d9a
to
f0ddb45
Compare
Thank you! |
fixes #621:
bukuserver/favicon.svg
filenote: it has to be 16x16 px to be displayed correctly in browser tabs, and not specifying a font results in a different icon being displayed in different browsers (possibly depending on various user font settings?)
/favicon.ico
route with permanent redirect to said filenote: once the browser got a 404 on favicon request, it stops requesting the favicon until you close and reopen the browser itself (private/incognito mode doesn't help); the workaround of loading the icon manually only works in Firefox
also:
.gitignore
to ensure they don't end up committed by accident