Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bukuserver] Tags-refresh action #628

Merged
merged 2 commits into from
Dec 2, 2022

Conversation

LeXofLeviafan
Copy link
Collaborator

fixes #608:

  • adding a "Refresh" button to the tags actions panel
  • implementing a POST endpoint to reload tags list

P.S. Is tags.html actually used anywhere? I get the feeling that about half of existing templates have been substituted completely by default flask-admin ones. (They seem to be mentioned in the code but these functions don't appear to be actually used anywhere…)

@rachmadaniHaryono
Copy link
Collaborator

is tags.html actually used anywhere?

looking at it, no. it is also old code

remove get_tags and update_tags from server.py and tags.html template

those are replaced by ApiTagView

@LeXofLeviafan
Copy link
Collaborator Author

The same seems to apply to search_bookmarks() (in server.py), as well as index.html (never used), bookmarks.html (used only in search_bookmarks()), and base.html (used only in index.html and bookmarks.html).

@rachmadaniHaryono
Copy link
Collaborator

those can be removed on other pr

@jarun jarun merged commit d02ba2a into jarun:master Dec 2, 2022
@jarun
Copy link
Owner

jarun commented Dec 2, 2022

Thank you!

@LeXofLeviafan LeXofLeviafan deleted the tags-refresh-action branch December 5, 2022 20:43
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tags list in bukuserver is never recalculated
3 participants