Minor format tweaks

[DanielYang59]

Early PR for adding heatmap to resolve #118.

[DanielYang59]

I notice matplotlib already has the interpolation method built in to allow interpolation of the plot, as stated here, by ax.imshow(grid, interpolation=interp_method, cmap='viridis').

In this case I think this entire code looks pointless, being a simple wrapper over imshow. Therefore I wish to remove this entire function altogether. However the heatmap itself looks good to me (it might not make sense to leave a standalone heatmap tutorial because pymatviz is a visualization package instead of a tutorial for matplotlib?)...Do you have any suggestions @janosh? Thanks.

[janosh]

In this case I think this entire code looks pointless, being a simple wrapper over imshow. Therefore I wish to remove this entire function altogether. However the heatmap itself looks good to me (it might not make sense to leave a standalone heatmap tutorial because pymatviz is a visualization package instead of a tutorial for matplotlib?)

yes, that sounds sensible! we can turn this a into an example/docs PR showing people how to use ax.imshow() to make element-matrix heat maps

[DanielYang59]

@janosh Can you please review this as a minor format tweak and I would open another PR for the periodic table scatter plotter? Thanks!

[janosh]

thanks @DanielYang59! better comments and more tests are always appreciated! 👍

[DanielYang59]

Thanks @janosh! I would also add guides and assert generations for ptable_hist in the following PR.

[DanielYang59]

Meanwhile I pushed the combine_colormap function to upstream CMasher at 1313e/CMasher/pull/122. Hopefully it could get accepted 😁.

[DanielYang59]

Meanwhile I pushed the combine_colormap function to upstream CMasher at 1313e/CMasher/pull/122. Hopefully it could get accepted 😁.

A quick update on this @janosh , after a month's review it finally get merged (really learned a lot about details in coding during this process), and it's now available as, detailed in the manual:

from cmasher import combine_cmaps

cmr.combine_cmaps(cmap_0, cmap_1)

[janosh]

nice, glad you found a good home for it! great team work between you and the maintainers on that PR 👍