Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] [Self-assigned] Add heatmap plotter #118

Closed
DanielYang59 opened this issue Jan 3, 2024 · 4 comments · Fixed by #120
Closed

[Feature] [Self-assigned] Add heatmap plotter #118

DanielYang59 opened this issue Jan 3, 2024 · 4 comments · Fixed by #120

Comments

@DanielYang59
Copy link
Collaborator

DanielYang59 commented Jan 3, 2024

Hi @janosh, I happen to have some plotting scripts for my MPhil research which includes plotting heatmaps. Shall I proceed and try to merge them into your package?

For example:
headmap1

And this (I didn't find a good way to fix these overlapping labels though):
heatmap2

@janosh
Copy link
Owner

janosh commented Jan 3, 2024

Certainly, if you can turn these figures into generic reusable functions and provide the specific outputs above as usage examples in the examples/ folder, that would be great! 👍

@DanielYang59
Copy link
Collaborator Author

@janosh Sure thanks. I would look into your existing codes and try to unify the function input/output flow. Cheers!

@janosh
Copy link
Owner

janosh commented Jan 3, 2024

Happy to help. Feel free to open a PR early and we can iterate together.

@DanielYang59
Copy link
Collaborator Author

DanielYang59 commented Jan 4, 2024

@janosh Thanks for offering that. However I might prefer to take my time and format the code on my own pace for the time being. I mean no offence but your energy is crazy, there is no way for me to catch up haha... Also coding is quite new to me (around only ~1 year experience) plus I'm current busy cleaning up my Journal Paper from my previous MPhil Thesis to support my future PhD position searching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants