Migrate site/ to Svelte 5
#210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoping it has SSR support and fixes
Serialized Error: { component_stack: [ 'Icon.svelte', 'ModelCard.svelte', '+page.svelte' ] }
This error originated in "tests/models-page.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
This error was caught after test environment was torn down. Make sure to cancel any running tasks before test finishes:
- cancel timeouts using clearTimeout and clearInterval
- wait for promises to resolve using the await keyword
⎯⎯⎯⎯⎯ Uncaught Exception ⎯⎯⎯⎯⎯
ReferenceError: document is not defined
in Icon.svelte
in ModelCard.svelte
in +page.svelte
❯ consequent_1 node_modules/@iconify/svelte/dist/Icon.svelte:133:43
121| <span {...data.attributes}></span>
122| {/if}
123| {/if}
| ^
124|
❯ node_modules/@iconify/svelte/dist/Icon.svelte:165:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preps new task pages that need recent features in
elementariwhich already migrated to Svelte 5 so need to follow suitmigrated to
iconify-iconfor SSR support based on this iconify/iconify#350 (comment)