Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider pinning Pymatviz #209

Closed
DeNeutoy opened this issue Feb 17, 2025 · 2 comments
Closed

Consider pinning Pymatviz #209

DeNeutoy opened this issue Feb 17, 2025 · 2 comments

Comments

@DeNeutoy
Copy link
Contributor

Pymatviz changes frequently - this is not a problem, apart from the fact that it pymatviz is not pinned in matbench discovery. This makes it tricky to keep old installations working, because released versions of matbench e.g v1.3.1 do not specify an upper bound for pymatviz. For example, this commit: janosh/pymatviz@ab691bb breaks all installed versions of matbench_discovery which are not main, because the package is not pinned.

I think given pymatviz is not a library which is super general (like torch or numpy), it might be safe and not disruptive to end users of matbench to pin the version. This is related to #145

Thanks!

@janosh
Copy link
Owner

janosh commented Feb 17, 2025

that's a good point! admittedly it's been the wild west of breaking changes, especially around end of last year. i think they'll be less frequent going forward, at least on the pymatviz side. you're right though, a strict version pin might help as each commit in this repo should be compatible with the latest pymatviz at the time. i'll add that

@DeNeutoy
Copy link
Contributor Author

that would be great, thanks 🙏

janosh added a commit that referenced this issue Feb 18, 2025
@janosh janosh closed this as completed in e1d57cc Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants