Introduce OTLP receiver configuration flags #3710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report
@@ Coverage Diff @@
## main #3710 +/- ##
==========================================
+ Coverage 97.40% 97.49% +0.09%
==========================================
Files 269 269
Lines 15856 15934 +78
==========================================
+ Hits 15444 15535 +91
+ Misses 326 315 -11
+ Partials 86 84 -2
Continue to review full report at Codecov.
|
yurishkuro
force-pushed
the
otlp-receiver-config
branch
2 times, most recently
from
63b3352
to
4ffcf5d
Compare
yurishkuro
commented
May 29, 2022
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package flags |
There was a problem hiding this comment.
this was a move from app/flags.go, but unfortunately git does not recognize it as move due to many changes.
There was a problem hiding this comment.
This commit shows the actual diffs cb6a8c9
yurishkuro
force-pushed
the
otlp-receiver-config
branch
from
4ffcf5d
to
92695ba
Compare
yurishkuro
changed the title
|
@albertteoh would you like to review this one too? |
albertteoh
previously approved these changes
May 30, 2022
Comment on lines
113
to
114
| createTracesReceiver := func(_ context.Context, _ component.ReceiverCreateSettings, | ||
| _ config.Receiver, _ consumer.Traces) (component.TracesReceiver, error) { |
There was a problem hiding this comment.
nit: Since none of the params are used, they can be removed altogether; it's not necessary to add the blank identifiers. Same with above newTraces := func(...).
Suggested change
| createTracesReceiver := func(_ context.Context, _ component.ReceiverCreateSettings, | |
| _ config.Receiver, _ consumer.Traces) (component.TracesReceiver, error) { | |
| createTracesReceiver := func(context.Context, component.ReceiverCreateSettings, | |
| config.Receiver, consumer.Traces) (component.TracesReceiver, error) { |
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
force-pushed
the
otlp-receiver-config
branch
from
dc4e6ea
to
068fe18
Compare
|
Thanks for the review, @albertteoh |
albertteoh
pushed a commit
to albertteoh/jaeger
that referenced
this pull request
Jul 13, 2022
Signed-off-by: Albert Teoh <see.kwang.teoh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3625.