Add OTLP receiver to collector #3701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
commented
May 25, 2022
Codecov Report
@@ Coverage Diff @@
## main #3701 +/- ##
==========================================
+ Coverage 97.34% 97.44% +0.10%
==========================================
Files 268 269 +1
Lines 15752 15842 +90
==========================================
+ Hits 15333 15438 +105
+ Misses 330 320 -10
+ Partials 89 84 -5
Continue to review full report at Codecov.
|
yurishkuro
force-pushed
the
otlp-receiver
branch
2 times, most recently
from
1f7a70c
to
8ae69d1
Compare
4 tasks
|
@albertteoh care to review? |
albertteoh
previously approved these changes
May 28, 2022
| logger.Fatal("Failed to start collector", zap.Error(err)) | ||
| } | ||
|
|
||
| // Wait for shutfown |
There was a problem hiding this comment.
Suggested change
| // Wait for shutfown | |
| // Wait for shutdown |
| expectErr error | ||
| expectLog string | ||
| }{ | ||
| {}, // no errors |
There was a problem hiding this comment.
I would add a test name or description so there won't be a need for this comment. i.e.:
{name: "no errors"},
...
t.Run(test.name, func(t *testing.T) {...
It has the added benefit of a more descriptive test name in logs when executing the test.
Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Albert <26584478+albertteoh@users.noreply.github.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
commented
May 29, 2022
| @@ -84,6 +84,11 @@ type CollectorOptions struct { | |||
| // See gRPC's keepalive.ServerParameters#MaxConnectionAgeGrace. | |||
| MaxConnectionAgeGrace time.Duration | |||
| } | |||
| // OTLP section defines options for servers accepting OpenTelemetry OTLP format | |||
| OTLP struct { | |||
yurishkuro
commented
May 29, 2022
| var _ component.Host = (*otelHost)(nil) // API check | ||
|
|
||
| // OtelReceiverOptions allows configuration of the receiver. | ||
| type OtelReceiverOptions struct { |
|
thanks for the review @albertteoh |
albertteoh
added a commit
to albertteoh/jaeger
that referenced
this pull request
Jul 13, 2022
Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Albert <26584478+albertteoh@users.noreply.github.com> Signed-off-by: Albert Teoh <see.kwang.teoh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proof-of-concept of adding an OTLP receiver (#3625) to Jaeger collector/all-in-one.
component.Host)Testing with this little program https://gist.github.com/yurishkuro/c60011b9b3b3e6b5c11f0852f877a6c3 produces a trace like this:
