Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move .gitignore deeper to keep the actual/ dir in the repo #3698

Merged
merged 1 commit into from
May 25, 2022

Conversation

yurishkuro
Copy link
Member

May fix #3697

Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #3698 (d6b328b) into main (04a5fdb) will increase coverage by 0.74%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3698      +/-   ##
==========================================
+ Coverage   96.59%   97.34%   +0.74%     
==========================================
  Files         268      268              
  Lines       15689    15745      +56     
==========================================
+ Hits        15155    15327     +172     
+ Misses        445      330     -115     
+ Partials       89       88       -1     
Impacted Files Coverage Δ
pkg/config/tlscfg/cert_watcher.go 92.63% <0.00%> (-2.11%) ⬇️
cmd/query/app/static_handler.go 95.80% <0.00%> (-1.80%) ⬇️
cmd/env/command.go 100.00% <0.00%> (ø)
plugin/metrics/factory.go 100.00% <0.00%> (ø)
plugin/storage/es/factory.go 97.61% <0.00%> (ø)
plugin/storage/grpc/factory.go 95.08% <0.00%> (ø)
plugin/storage/kafka/factory.go 100.00% <0.00%> (ø)
plugin/storage/badger/factory.go 95.80% <0.00%> (ø)
plugin/storage/memory/factory.go 100.00% <0.00%> (ø)
plugin/metrics/disabled/factory.go 100.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04a5fdb...d6b328b. Read the comment docs.

@yurishkuro yurishkuro merged commit 6094220 into jaegertracing:main May 25, 2022
@yurishkuro yurishkuro deleted the move-gitignore branch May 25, 2022 17:04
albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request Jul 13, 2022
yurishkuro added a commit that referenced this pull request Aug 10, 2022
Follow-up to #3698

Signed-off-by: Yuri Shkuro <github@ysh.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go mod vendor fails when module depends on jaeger
1 participant