Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go mod vendor fails when module depends on jaeger #3697

Closed
wpcarro opened this issue May 25, 2022 · 2 comments · Fixed by #3698
Closed

go mod vendor fails when module depends on jaeger #3697

wpcarro opened this issue May 25, 2022 · 2 comments · Fixed by #3698
Labels

Comments

@wpcarro
Copy link

wpcarro commented May 25, 2022

I originally reported this issue here: timescale/promscale#1374

$ go mod vendor -v # from promscale repo at 0.11.0
# github.com/jaegertracing/jaeger v1.33.0
## explicit
github.com/jaegertracing/jaeger/cmd/collector/app/sampling/model
github.com/jaegertracing/jaeger/cmd/query/app
github.com/jaegertracing/jaeger/cmd/query/app/apiv3
github.com/jaegertracing/jaeger/cmd/query/app/querysvc
github.com/jaegertracing/jaeger/cmd/query/app/ui
go mod vendor: pattern actual/*: no matching files found

I'm posting here in case this is a bug with jaeger. As I said in the other issue, I'm a golang n00b, so I'm not sure who's (if anyone) is at fault. I'm not even sure if my expectations are correct. I just expected to be able to call go mod vendor on the promscale repo and have that command succeed.

Any ideas?

@yurishkuro
Copy link
Member

it's probably because of this:

//go:embed actual/*

There is no actual/ directory in the git repo, it is only created when the real UI assets are built and copied there. I created #3698, please try updating promscale to use that branch & see if it fixes your issue.

@wpcarro
Copy link
Author

wpcarro commented May 25, 2022

Thanks for the quick response. Calling go mod vendor is now working as expected :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants