Add sasl plain auth kafka plugin #1855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kend (jaegertracing#1845) * Add SASL Plain configuration options and SASL Plain configuration set up Signed-off-by: somnath <somnath.ghosh@honeywell.com>
…kend (jaegertracing#1845) * Update config paramaters for sasl plain input to have sasl plain prefix Signed-off-by: somnath <somnath.ghosh@honeywell.com>
…kend (jaegertracing#1845) * refactor SASL Plain configuration to check for valid username/password before enabling configuration Signed-off-by: somnath <somnath.ghosh@honeywell.com>
somnathnitb
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
yurishkuro
reviewed
Oct 11, 2019
| func addSASLPlainFlags(configPrefix string, flagSet *flag.FlagSet) { | ||
| flagSet.String( | ||
| configPrefix+saslPlainPrefix+suffixSASLUsername, | ||
| defaultSASLUsername, |
| "Username for SASL Plain authentication") | ||
| flagSet.String( | ||
| configPrefix+saslPlainPrefix+suffixSASLPassword, | ||
| defaultSASLPassword, |
…kend (jaegertracing#1845) * add option to enable/disable TLS for transport. TLS can be enabled/disabled irrespective of authentication mechanism. Signed-off-by: somnath <somnath.ghosh@honeywell.com>
yurishkuro
reviewed
Oct 15, 2019
pkg/kafka/auth/config.go
Outdated
| @@ -39,6 +39,7 @@ var authTypes = []string{ | |||
| // AuthenticationConfig describes the configuration properties needed authenticate with kafka cluster | |||
| type AuthenticationConfig struct { | |||
| Authentication string | |||
| TlsEnabled bool | |||
…kend (jaegertracing#1845) * Revert Support for TLS as it will handled with issue jaegertracing#1838 Signed-off-by: somnath <somnath.ghosh@honeywell.com>
|
@somnathnitb do you have cycles to finish this PR? |
|
Closing thanks for the PR. Jaeger already supports plain auth for Kafka. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Issue #1845 As of today Jaeger Kafka plugin only supports SASL GSSPI (Kerberos) and certificate-based authentication (mutual TLS). However, not all Kafka deployments support this authentication mechanism. we have a Kafka cluster deployed with TLS transport for communication however our authentication is set up to use SASL PLAIN. https://docs.confluent.io/current/kafka/authentication_sasl/authentication_sasl_plain.html#kafka-sasl-auth-plain
Short description of the changes
Added new authentication configuration for SASL Plain.
New SASL Plain configuration options