Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for SASL PLAIN authentication for Collector Kafka Storage Backend #1845

Closed
somnathnitb opened this issue Oct 9, 2019 · 4 comments
Closed

Support for SASL PLAIN authentication for Collector Kafka Storage Backend #1845

somnathnitb opened this issue Oct 9, 2019 · 4 comments

Comments

@somnathnitb
Copy link

Kafka supports different types of authentication mechanisms. As of today collector for Kafka storage backend only supports SASL GSSPI (Kerberos) and certificate-based authentication (mutual TLS). However, not all Kafka deployments support this authentication mechanism.
In our case, we have a Kafka cluster deployed with TLS transport for communication however our authentication is set up to use SASL PLAIN https://docs.confluent.io/current/kafka/authentication_sasl/authentication_sasl_plain.html#kafka-sasl-auth-plain. Can we add support for SASL PLAIN authentication for the collector with Kafka as storage backend?
@jpkrohling
Copy link
Contributor

Yes, if it's only adding a new auth mechanism to an existing storage backend, it will certainly be accepted! Check CONTRIBUTING.md for more info on what's expected from your PR.

@somnathnitb
Copy link
Author

@jpkrohling how can I get contributor access here so that I can push my branch and raise PR?

@yurishkuro
Copy link
Member

Please fork this repo, create a branch in the fork, and then you'll be able to create a pull request from that branch. See https://help.github.com/en/articles/about-pull-requests

somnathnitb pushed a commit to somnathnitb/jaeger that referenced this issue Oct 11, 2019
@somnathghoshhon
Support for SASL PLAIN authentication for Collector Kafka Storage Bac…
8b7909d 
…kend (jaegertracing#1845)

* Add SASL Plain configuration options and SASL Plain configuration set up

Signed-off-by: somnath <somnath.ghosh@honeywell.com>
somnathnitb pushed a commit to somnathnitb/jaeger that referenced this issue Oct 11, 2019
@somnathghoshhon
Support for SASL PLAIN authentication for Collector Kafka Storage Bac…
98c804e 
…kend (jaegertracing#1845)

* Update config paramaters for sasl plain input to have sasl plain prefix

Signed-off-by: somnath <somnath.ghosh@honeywell.com>
somnathnitb pushed a commit to somnathnitb/jaeger that referenced this issue Oct 11, 2019
@somnathghoshhon
Support for SASL PLAIN authentication for Collector Kafka Storage Bac…
1d3e1b5 
…kend (jaegertracing#1845)

* refactor SASL Plain configuration to check for valid username/password before enabling configuration

Signed-off-by: somnath <somnath.ghosh@honeywell.com>
@somnathnitb somnathnitb mentioned this issue Oct 11, 2019
Closed
somnathnitb pushed a commit to somnathnitb/jaeger that referenced this issue Oct 15, 2019
@somnathghoshhon
Support for SASL PLAIN authentication for Collector Kafka Storage Bac…
981e8c7 
…kend (jaegertracing#1845)

* add option to enable/disable TLS for transport. TLS can be enabled/disabled irrespective of authentication mechanism.

Signed-off-by: somnath <somnath.ghosh@honeywell.com>
somnathnitb pushed a commit to somnathnitb/jaeger that referenced this issue Oct 17, 2019
@somnathghoshhon
Support for SASL PLAIN authentication for Collector Kafka Storage Bac…
63c440a 
…kend (jaegertracing#1845)

* Revert Support for TLS as it will handled with issue jaegertracing#1838

Signed-off-by: somnath <somnath.ghosh@honeywell.com>
@pavolloffay
Copy link
Member

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jpkrohling @yurishkuro @pavolloffay @somnathnitb