Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some utils public to ease transition #1730

Merged
merged 4 commits into from
Aug 14, 2019

Conversation

yurishkuro
Copy link
Member

This makes it easier to reconcile our internal code with oss as part of the move (#365).

Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #1730 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1730   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         193      193           
  Lines        9364     9364           
=======================================
  Hits         9211     9211           
  Misses        119      119           
  Partials       34       34
Impacted Files Coverage Δ
...mpling/strategystore/adaptive/weightvectorcache.go 100% <100%> (ø) ⬆️
...lugin/sampling/strategystore/adaptive/processor.go 100% <100%> (ø) ⬆️
plugin/sampling/strategystore/adaptive/cache.go 100% <100%> (ø) ⬆️
...ugin/sampling/strategystore/adaptive/floatutils.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2724a58...1f86158. Read the comment docs.

Yuri Shkuro added 2 commits August 14, 2019 01:05
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
@yurishkuro yurishkuro merged commit 75b670f into jaegertracing:master Aug 14, 2019
@yurishkuro yurishkuro deleted the refactor-public branch August 14, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants