[Bug]: jaegertracing/all-in-one:latest does not match the latest Docker versioned tag nor the latest git tag
#5721
Comments
erezrokah
changed the title
jaegertracing/all-in-one:latest does not match the latest Docker tag nor the latest git tagjaegertracing/all-in-one:latest does not match the latest Docker versioned tag nor the latest git tag
|
Could be that latest represent the latest commit on |
|
I think this is how we historically have the CI set up, where I agree that this is not ideal. We have separate "snapshot" repositories (e.g. https://hub.docker.com/r/jaegertracing/all-in-one-snapshot) where that definition of latest would make more sense (but in fact |
yurishkuro
added
help wanted
|
#5724 should fix the 2nd issue, the main issue (only include |
|
One challenge we may run into just removing |
|
Thanks for the quick response and fix. Maybe there's a place we can update the docs regarding the Docker latest tag referencing the latest commit? I think that would satisfy my issue |
|
Hi I was attempting to solve the first issue and while still exploring the probable causes for the issue I noticed this on the docker hub
is getting the info that is being displayed above so could i know where to look at to understand it even better |
|
@vvs-personalstash 1.58.1 is the real label that matters. 1.58 simply points to the latest patch, just like |
yurishkuro
removed
help wanted
|
Oh sorry it seems i misunderstood that |
## Which problem is this PR solving? - To address #5721, add unit tests first ## Description of the changes - Add unit tests and call them from scripts linting workflow - Minor refactoring of `scripts/compute-tags.sh` to make it easier to read ## How was this change tested? ``` $ GREP=ggrep SHUNIT2=/Users/ysh/dev/shunit2 bash scripts/compute-tags.test.sh testRequireImageName testRequireBranch testRequireGithubSha testRandomBranch Actual: --tag docker.io/foo/bar --tag quay.io/foo/bar --tag docker.io/foo/bar:latest --tag quay.io/foo/bar:latest --tag docker.io/foo/bar-snapshot:sha --tag quay.io/foo/bar-snapshot:sha --tag docker.io/foo/bar-snapshot:latest --tag quay.io/foo/bar-snapshot:latest checking foo/bar checking foo/bar:latest checking foo/bar-snapshot:sha checking foo/bar-snapshot:latest testMainBranch Actual: --tag docker.io/foo/bar --tag quay.io/foo/bar --tag docker.io/foo/bar:latest --tag quay.io/foo/bar:latest --tag docker.io/foo/bar-snapshot:sha --tag quay.io/foo/bar-snapshot:sha --tag docker.io/foo/bar-snapshot:latest --tag quay.io/foo/bar-snapshot:latest checking foo/bar checking foo/bar:latest checking foo/bar-snapshot:sha checking foo/bar-snapshot:latest testSemVerBranch Actual: --tag docker.io/foo/bar --tag quay.io/foo/bar --tag docker.io/foo/bar:1.2.3 --tag quay.io/foo/bar:1.2.3 --tag docker.io/foo/bar:1.2 --tag quay.io/foo/bar:1.2 --tag docker.io/foo/bar:1 --tag quay.io/foo/bar:1 --tag docker.io/foo/bar-snapshot:sha --tag quay.io/foo/bar-snapshot:sha --tag docker.io/foo/bar-snapshot:latest --tag quay.io/foo/bar-snapshot:latest checking foo/bar checking foo/bar:1 checking foo/bar:1.2 checking foo/bar:1.2.3 checking foo/bar-snapshot:sha checking foo/bar-snapshot:latest Ran 6 tests. OK ``` --------- Signed-off-by: Yuri Shkuro <github@ysh.us>
|
Doesn't look like #5781 worked, probably need to remove no-version tags altogether |
## Which problem is this PR solving? - Resolves #5721 - The previous PR #5781 didn't quite work because we were still applying tags like `--tag docker.io/foo/bar` (without a version), which evidently leads Docker to treat them as `:latest`, which is exactly what we are trying to avoid for `main` branch ## Description of the changes - Remove usage of no-version tags `--tag docker.io/foo/bar` completely - Fix unit tests, make them stricter ## How was this change tested? - Unit tests Signed-off-by: Yuri Shkuro <github@ysh.us>
What happened?
More of a question to see if this is a bug.
Looking at the Docker versions, the latest version was published 19 hours ago, while
1,1.58,1.58.1were published 17 days ago. Is that expected?Also running the latest version hints that it was built from the
1.58.0git tag but with a newer build time than1.58.1⬇️1.58loads as1.58.1:latestloads as1.58.0but newer build dateSteps to reproduce
Run
docker run -e COLLECTOR_OTLP_ENABLED=true -p 16686:16686 -p 4318:4318 jaegertracing/all-in-one:1.58vsdocker run -e COLLECTOR_OTLP_ENABLED=true -p 16686:16686 -p 4318:4318 jaegertracing/all-in-one:latest.Expected behavior
latestDocker tag should have a matching versioned tag on Docker hub, and it should match a git tag.Relevant log output
No response
Screenshot
No response
Additional context
Not sure if this is actually a bug or expected behavior. Please close if I missed anything
Jaeger backend version
No response
SDK
No response
Pipeline
No response
Stogage backend
No response
Operating system
No response
Deployment model
No response
Deployment configs
No response
The text was updated successfully, but these errors were encountered: