[Bug]: spanmetrics via connector not working with otel-collector v0.80.0 #4547
Labels
Comments
Multiply
changed the title
|
Thanks for letting us know, @Multiply. My mistake for not recognising the behaviour was caused by a feature gate in the first place! Will take a look. |
|
I'll be happy to test both locally and in production when something lands! |
albertteoh
added a commit
that referenced
this issue
Jun 29, 2023
## Which problem is this PR solving? - Resolves #4547 ## Short description of the changes - Adds the following boolean parameters to declaratively determine whether the metric name should be modified to match normalization rules as defined [here](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/prometheus/README.md): - `prometheus.query.normalize-calls` - `prometheus.query.normalize-duration` - Separate flags intentional to allow support for backwards compatibility with older OpenTelemetry Collector versions. A single flag is insufficient. - Motivated by a breaking change in: https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.80.0. --------- Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
afzal442
pushed a commit
to Cloud-Hacks/jaeger
that referenced
this issue
Jul 10, 2023
## Which problem is this PR solving? - Resolves jaegertracing#4547 ## Short description of the changes - Adds the following boolean parameters to declaratively determine whether the metric name should be modified to match normalization rules as defined [here](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/prometheus/README.md): - `prometheus.query.normalize-calls` - `prometheus.query.normalize-duration` - Separate flags intentional to allow support for backwards compatibility with older OpenTelemetry Collector versions. A single flag is insufficient. - Motivated by a breaking change in: https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.80.0. --------- Signed-off-by: albertteoh <see.kwang.teoh@gmail.com> Signed-off-by: Afzal Ansari <afzal442@gmail.com>
Monstergogo
added a commit
to Monstergogo/beauty-share
that referenced
this issue
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
The
durationmetric name is no longer normalized with the unit type by default.The feature gate has been reverted back to off by default, see more details here: https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.80.0
Steps to reproduce
When trying to run the docker-compose monitor example, no data is visible in Jaeger's Monitor tab.
Expected behavior
I expect Jaeger to support both normalized and non-normalized metrics names, or at least document the need to have the feature gate enabled.
Relevant log output
No response
Screenshot
No response
Additional context
No response
Jaeger backend version
v1.46.0
SDK
OpenTelemetry Collector v0.80.0
Pipeline
The default provided in the docker-compose monitor example.
Stogage backend
No response
Operating system
No response
Deployment model
No response
Deployment configs
No response
The text was updated successfully, but these errors were encountered: