Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve configuration parameters for Kafka #1359

Closed
geobeau opened this issue Feb 18, 2019 · 2 comments · Fixed by #1712
Closed

Improve configuration parameters for Kafka #1359

geobeau opened this issue Feb 18, 2019 · 2 comments · Fixed by #1712
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@geobeau
Copy link
Contributor

geobeau commented Feb 18, 2019 •
edited
Loading

Requirement - what kind of business use case are you trying to solve?

Kafka supports a lot of parameters and Jaeger provide the user only a handful (Brokers, topic, group-id).

Problem - what in Jaeger blocks you from solving the requirement?

Jaeger should be able support a parameter for API version.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Add them in the configuration of the ingester and collector.
Other relevant parameters:

  • Producer.RequiredAcks
  • Producer.CompressionLevel
  • Consumer.Fetch.Default

Any open questions to address

What other parameters should be supported by jaeger?

(I'll will try to tackle this issue when I'll have time but help or feedback on parameters to add would be very nice)
@yurishkuro yurishkuro added help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels Feb 18, 2019
@chandresh-pancholi
Copy link
Contributor

I would like to work on it.

@geobeau
Copy link
Contributor Author

geobeau commented Feb 20, 2019

Thanks !

chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue May 7, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
61f5f8f 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
@chandresh-pancholi chandresh-pancholi mentioned this issue May 7, 2019
Closed
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue May 7, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
7ad7d93 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue May 9, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
a7b5a7c 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue May 19, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
c78787d 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue May 19, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
b24a545 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue May 20, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
d000804 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue May 20, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
01f7c1a 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
@chandresh-pancholi chandresh-pancholi mentioned this issue May 20, 2019
Closed
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue May 22, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka.(jaegertracing#1359)
923c386 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
@chandresh-pancholi chandresh-pancholi mentioned this issue Jul 19, 2019
Closed
chandresh-pancholi pushed a commit to chandresh-pancholi/jaeger that referenced this issue Jul 30, 2019
Improve configuration parameters for Kafka jaegertracing#1359
4725aed 
Signed-off-by: Chandresh Pancholi <Chandresh@ip-192-168-0-104.ap-south-1.compute.internal>
@chandresh-pancholi chandresh-pancholi mentioned this issue Jul 30, 2019
Closed
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Jul 30, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
99c0b9a 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Jul 31, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
8e4bf36 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Jul 31, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
9b9e73c 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Aug 1, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
ea6ed92 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Aug 1, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
c6c8f00 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Aug 1, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
7f25d62 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Aug 6, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
c505027 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Aug 6, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
8687ede 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Aug 6, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
b8a0e5d 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
@chandresh-pancholi chandresh-pancholi mentioned this issue Aug 6, 2019
Merged
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Aug 8, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
456af4d 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Aug 9, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
f2aa186 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Aug 9, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
85e1a37 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Aug 9, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
6974ec5 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Aug 9, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
0301d0c 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Aug 9, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
c17bbef 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Aug 9, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
2e09505 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Aug 20, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
f43a8cd 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Aug 20, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
cc6360d 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Aug 20, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
2491996 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Sep 10, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
441c23a 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Sep 10, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
0c22184 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Sep 11, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
8bd740b 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Sep 11, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
90e43d2 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi added a commit to chandresh-pancholi/jaeger that referenced this issue Sep 11, 2019
@chandresh-pancholi
Improve configuration parameters for Kafka jaegertracing#1359
e5582d9 
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ack and compression parameters for Kafka #1359 chandresh-pancholi/jaeger
3 participants
@chandresh-pancholi @yurishkuro @geobeau