Improve configuration parameters for Kafka jaegertracing#1359

Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi · May 19, 2019 · c78787d · c78787d
1 parent 48b255b
commit c78787d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/plugin/storage/kafka/options.go b/plugin/storage/kafka/options.go
@@ -97,6 +97,7 @@ func (opt *Options) InitFromViper(v *viper.Viper) {
 	opt.config = producer.Configuration{
 		Brokers:          strings.Split(stripWhiteSpace(v.GetString(configPrefix+suffixBrokers)), ","),
 		RequiredAcks:     v.GetInt(configPrefix + suffixRequiredAcks),
+		Compression:      v.GetInt(configPrefix + suffixCompression),
 		CompressionLevel: v.GetInt(configPrefix + suffixCompressionLevel),
 	}
 	opt.topic = v.GetString(configPrefix + suffixTopic)

diff --git a/plugin/storage/kafka/options_test.go b/plugin/storage/kafka/options_test.go
@@ -30,16 +30,16 @@ func TestOptionsWithFlags(t *testing.T) {
 		"--kafka.producer.brokers=127.0.0.1:9092, 0.0.0:1234",
 		"--kafka.producer.encoding=protobuf",
 		"--kafka.producer.required.acks=1",
-		"--kafka.producer.compression=0",
-		"--kafka.producer.compression.level=-1000"})
+		"--kafka.producer.compression=1",
+		"--kafka.producer.compression.level=6"})
 	opts.InitFromViper(v)
 
 	assert.Equal(t, "topic1", opts.topic)
 	assert.Equal(t, []string{"127.0.0.1:9092", "0.0.0:1234"}, opts.config.Brokers)
 	assert.Equal(t, "protobuf", opts.encoding)
 	assert.Equal(t, 1, opts.config.RequiredAcks)
-	assert.Equal(t, 0, opts.config.Compression)
-	assert.Equal(t, -1000, opts.config.CompressionLevel)
+	assert.Equal(t, 1, opts.config.Compression)
+	assert.Equal(t, 6, opts.config.CompressionLevel)
 }
 
 func TestFlagDefaults(t *testing.T) {