Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clear console errors (proptype violations) from CLI output #615

Merged
merged 1 commit into from
Aug 12, 2020
Merged

clear console errors (proptype violations) from CLI output #615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/jaeger-ui/src/components/SearchTracePage/SearchForm.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ const DATE_FORMAT = 'YYYY-MM-DD';
const TIME_FORMAT = 'HH:mm';
const defaultProps = {
dataCenters: ['dc1'],
handleSubmit: () => {},
searchMaxLookback: {
label: '2 Days',
value: '2d',
Expand Down
4 changes: 2 additions & 2 deletions packages/jaeger-ui/src/components/SearchTracePage/SearchResults/ResultItem.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import transformTraceData from '../../../model/transform-trace-data';
const trace = transformTraceData(traceGenerator.trace({}));

it('<ResultItem /> should render base case correctly', () => {
const wrapper = shallow(<ResultItem trace={trace} durationPercent={50} />);
const wrapper = shallow(<ResultItem trace={trace} durationPercent={50} linkTo="" />);
const numberOfSpanText = wrapper
.find(`[data-test="${markers.NUM_SPANS}"]`)
.first()
Expand All @@ -36,7 +36,7 @@ it('<ResultItem /> should render base case correctly', () => {
});

it('<ResultItem /> should not render any ServiceTags when there are no services', () => {
const wrapper = shallow(<ResultItem trace={{ ...trace, services: [] }} durationPercent={50} />);
const wrapper = shallow(<ResultItem trace={{ ...trace, services: [] }} durationPercent={50} linkTo="" />);
const serviceTags = wrapper.find(`[data-test="${markers.SERVICE_TAGS}"]`).find(Tag);
expect(serviceTags).toHaveLength(0);
});