clear console errors (proptype violations) from CLI output #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests, due to missing required props, were leaving console.error messages in the test run CLI output. It doesn't effect the tests, it doesn't cause any false positives or negatives, but it could be seen as a distraction seeing red output fly across the screen in an otherwise passing test. Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com>
Codecov Report
@@ Coverage Diff @@
## master #615 +/- ##
==========================================
- Coverage 92.70% 92.67% -0.04%
==========================================
Files 227 227
Lines 5911 5911
Branches 1491 1491
==========================================
- Hits 5480 5478 -2
- Misses 390 392 +2
Partials 41 41
Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Aug 12, 2020
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 4, 2021
…cing#615) These tests, due to missing required props, were leaving console.error messages in the test run CLI output. It doesn't effect the tests, it doesn't cause any false positives or negatives, but it could be seen as a distraction seeing red output fly across the screen in an otherwise passing test. Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 4, 2021
…cing#615) These tests, due to missing required props, were leaving console.error messages in the test run CLI output. It doesn't effect the tests, it doesn't cause any false positives or negatives, but it could be seen as a distraction seeing red output fly across the screen in an otherwise passing test. Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
…cing#615) These tests, due to missing required props, were leaving console.error messages in the test run CLI output. It doesn't effect the tests, it doesn't cause any false positives or negatives, but it could be seen as a distraction seeing red output fly across the screen in an otherwise passing test. Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes