Provided CA parameter to pass to the tls socket connection and socket error non ECONNREFUSED reporting #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added the ```ca``` options to provide an array with the CAs that winston-logstash secure socket accept, so it is provided to node client secure socket connection. I also added a checking in socket ```error``` listener to report to transport eventEmitter when socket received an error different from ECONNREFUSED
I added a test to check the ca option and the error reporting so, I regenerated the certificates and keys and provided another to check which provoke an error on the transport socket to check the implemented error reporting. I also added a shell script to regenerate the server key and certificate
|
Thanks! Looks good. |
jaakkos
added a commit
that referenced
this pull request
Nov 15, 2013
Provided CA parameter to pass to the tls socket connection and socket error non ECONNREFUSED reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I provided a new option to the transport that it is passed straightaway to TLS socket connection as node method accepts.
It allows to drop errors for self-signed certificate, so I could pass the test in my machine, otherwise the test was stopped waiting infinitely in the 'secure connection' suite. I think that it is a change of node API in some release, launched after you used for tested it.
I also added to
socket.on('error', ...a check to emit an error to the transport when the socket receive an error different than ECONNREFUSED.