Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related with #6 #7 #8 issues #9

Closed
ifraixedes opened this issue Nov 14, 2013 · 1 comment
Closed

Related with #6 #7 #8 issues #9

ifraixedes opened this issue Nov 14, 2013 · 1 comment

Comments

@ifraixedes
Copy link
Contributor

Hi,
It is not a new issue, it is a comment for my 3 pull requests.
I wanted to tackle in reverse order, but when I tacked it, I realised of following one (#7) and after the last one (#6).

I don't know if it was better for you make three different pull request with each issue or one with all of them, but I thought better three different to better understanding what I tried to fix.

I know if you decide to merge #6 and after the next 2, those probably will have conflicts, so let me know if you decide to merge all of them and you need help with the possible conflicts.

@jaakkos
Copy link
Owner

jaakkos commented Nov 15, 2013

Merged them manually and fixed merge conflicts :)

@jaakkos jaakkos closed this as completed Nov 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants