fixes #339 Attribute nodes are expected to be named "Attr" #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it's easier/acceptable for you to commit individual PRs (which makes sense, seeing they are distinct fixes), then I'd welcome that :) Edit: Approved, will merge once you give the okay (don't want to create confusion/merge conflicts with your big PR) |
|
It's certainly not easier, but I know the equations of real life and it will hopefully make things merge quicker :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is includes in my behemoth PR as well, although refactoring makes it differ slightly. I figure it's better if I can produce a couple of smaller PR's, then merge them (and deal with the conflicts) before someone tackles the big PR.