Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shaders need to be declared in "correct" order #335

Closed
neph1 opened this issue May 20, 2022 · 1 comment
Closed

Shaders need to be declared in "correct" order #335

neph1 opened this issue May 20, 2022 · 1 comment
Labels
ShaderEditor ShaderNodes/PBR

Comments

@neph1
Copy link
Contributor

neph1 commented May 20, 2022

Or the shader won't compile as it looks for connections. This instantly becomes a problem when adding more than the standard Frag shader since they end up after it in the def file. I guess some kind of mapping is needed afterwards.
@neph1
Copy link
Contributor Author

neph1 commented May 22, 2022

I imagine this can be done in two ways.
My first thought was to load all into a Map and then find the connections from there. There'd need to be checks for cyclic dependencies, though.
Maybe it's easier to make sure they're saved in the correct order. That could be done with a Comparator, I believe, moving them down in the list if there is a dependency.

@neph1 neph1 mentioned this issue May 22, 2022
Merged
neph1 added a commit to neph1/sdk that referenced this issue May 25, 2022
@neph1
fixes jMonkeyEngine#335 properly. better sorting and sorting on new m…
9cc1417 
…apping
@neph1 neph1 closed this as completed in 605cc17 Aug 7, 2022
neph1 added a commit that referenced this issue Sep 12, 2022
@neph1
Previews for matparams (#334)
33831b7 
* Immediate updates
AssetManager static hack to load textures in preview...

* Previews for all matparams(?)
Updatable floats and colors

* Previews for all matparams(?)
Updatable floats and colors
(SDK Core project)

* Rich editors for colors, texture and float nodes. Simple editors for vecs and bools.

* Revert "Merge branch 'master' into previews_for_matparams"

This reverts commit 2d4920e, reversing
changes made to bed7dea.

* Merge branch 'master' into HEAD

# Conflicts:
#	jme3-core/src/com/jme3/gde/core/editor/nodes/NodePanel.java

* fixing disastreous merge commit

* one more file

* mending

* mending

* sorting for shadernodeblock. inclusive?

* live updates for backpanel

* clean up

* fixes #339 Attribute nodes are expected to be named "Attr"

* fixes #335 properly. better sorting and sorting on new mapping

* Revert "Immediate updates AssetManager static hack to load textures in preview..."

This reverts commit d08c87f.

* Clean up and documentation

* Reverted some unnecessary changes

* fixing line endings

* fixing line endings

* line endings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ShaderEditor ShaderNodes/PBR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@neph1