Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dunai-test: Remove deprecated functions #444

Closed
ivanperez-keera opened this issue Oct 22, 2024 · 3 comments
Closed

dunai-test: Remove deprecated functions #444

ivanperez-keera opened this issue Oct 22, 2024 · 3 comments
Labels
beginner help wanted maintenance
Milestone
Dunai 0.14.0

Comments

@ivanperez-keera
Copy link
Owner

dunai-test includes several deprecated definitions that were deprecated a year ago (see #385). They can safely be removed.
@ivanperez-keera ivanperez-keera added this to the Dunai 0.14.0 milestone Oct 22, 2024
@ivanperez-keera
Copy link
Owner Author

ivanperez-keera commented Oct 22, 2024 •
edited
Loading

If someone wants to do this, please go ahead and send a PR.

Please create 2 commits:

  • Commit 1: Remove all deprecated definitions from dunai-test/src/FRP/Dunai/LTLPast.hs.
  • Commit 2: Update dunai-test's changelog.

Please check out the recent history of this repository to see how we normally document commits, and how we link commits to issues in the subject line of the commit messages.

@ivanperez-keera ivanperez-keera changed the title Remove deprecated functions from dunai-test dunai-test: Remove deprecated functions Nov 3, 2024
@solomon-b
Copy link
Contributor

What about the deprecations in Control.Monad.Trans.MSF.List?

@solomon-b solomon-b mentioned this issue Nov 3, 2024
Closed
@ivanperez-keera
Copy link
Owner Author

ivanperez-keera commented Nov 3, 2024 •
edited
Loading

Hi @solomon-b . I opened a separate issue to deal with those: #445

It should be sent in a separate PR to this one. Thanks!

ivanperez-keera pushed a commit that referenced this issue Nov 3, 2024
@solomon-b @ivanperez-keera
dunai-test: Remove deprecated definitions from FRP.Dunai.LTLPast. Refs …
36a67fb 
…#444.

Module FRP.Dunai.LTLPast in dunai-test includes several deprecated
definitions that were deprecated a year ago. Per our policy to wait 3
versions until a deprecated definition can be removed, these function
can now be removed.

This commit removes deprecated functions from FRP.Dunai.LTLPast.
ivanperez-keera pushed a commit that referenced this issue Nov 3, 2024
@solomon-b @ivanperez-keera
dunai-test: Document changes in CHANGELOG. Refs #444.
21e1909
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner help wanted maintenance
Projects
None yet
Milestone
Dunai 0.14.0
Development

No branches or pull requests
2 participants
@solomon-b @ivanperez-keera