Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dunai-test: Reduce number of ways of defining past-time predicates #385

Closed
ivanperez-keera opened this issue Oct 22, 2023 · 0 comments
Closed

dunai-test: Reduce number of ways of defining past-time predicates #385

ivanperez-keera opened this issue Oct 22, 2023 · 0 comments
Assignees
@ivanperez-keera
Labels
enhancement
Milestone
Dunai 0.12.0

Comments

@ivanperez-keera
Copy link
Owner

ivanperez-keera commented Oct 22, 2023 •
edited
Loading

The FRP.Dunai.LTLPast module provides multiple ways of defining past-time predicates.

In comparison, Yampa only had some of those commented out, and they were eventually removed: ivanperez-keera/Yampa@b0c0846

For consistency, only one way should be provided in Dunai, unless the other one can be properly justified.
@ivanperez-keera ivanperez-keera self-assigned this Oct 22, 2023
ivanperez-keera added a commit that referenced this issue Oct 22, 2023
@ivanperez-keera
dunai-test: Deprecate one of multiple ptLTL implementations. Refs #385.
6137330 
The FRP.Dunai.LTLPast module provides multiple ways of defining
past-time predicates.

In comparison, Yampa only had those commented out, and they were
eventually removed.

This commit deprecates the way of writing past-time LTL predicates that
does not match what we have in Yampa.
ivanperez-keera added a commit that referenced this issue Oct 22, 2023
@ivanperez-keera
dunai-test: Document changes in CHANGELOG. Refs #385.
977ae24
ivanperez-keera added a commit that referenced this issue Oct 22, 2023
@ivanperez-keera
dunai-test: Deprecate one of multiple ptLTL implementations. Refs #385.
91935db 
The FRP.Dunai.LTLPast module provides multiple ways of defining
past-time predicates.

In comparison, Yampa only had the second set of combinators commented
out, and they were eventually removed.

This commit deprecates the way of writing past-time LTL predicates that
does not match what we have in Yampa.
ivanperez-keera added a commit that referenced this issue Oct 22, 2023
@ivanperez-keera
dunai-test: Document changes in CHANGELOG. Refs #385.
7e03711
@ivanperez-keera ivanperez-keera added this to the Dunai 0.12.0 milestone Oct 22, 2023
@ivanperez-keera ivanperez-keera mentioned this issue Oct 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanperez-keera ivanperez-keera

Labels
enhancement
Projects
None yet
Milestone
Dunai 0.12.0
Development

No branches or pull requests
1 participant
@ivanperez-keera