Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cml: resolve deadlock when cloning amis (#404) #405

Merged
merged 1 commit into from
Feb 20, 2022
Merged

cml: resolve deadlock when cloning amis (#404) #405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cml/clone-amis.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,10 @@ func main() {
ami := imagesRes.Images[0]

var wg sync.WaitGroup
wg.Add(len(regions))
0x2b3bfa0 marked this conversation as resolved.
Show resolved Hide resolved
for _, destination := range regions {
wg.Add(1)
go func(destinationRegion string) {
defer wg.Done()
fmt.Printf("Cloning image to region %s...\n", destinationRegion)
if err := cloneImage(region, destinationRegion, *ami.ImageId, *ami.Name, *ami.Description); err != nil {
fmt.Printf("Error cloning image to region %s\n", destinationRegion)
Expand Down