Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cml: resolve deadlock when cloning amis (#404) #405

Merged
merged 1 commit into from
Feb 20, 2022
Merged

cml: resolve deadlock when cloning amis (#404) #405

merged 1 commit into from
Feb 20, 2022

Conversation

redouan-rhazouani
Copy link
Contributor

  • Each goroutine must call wg.Done() otherwise wg.Wait() forever

@redouan-rhazouani
cml: resolve deadlock when cloning amis (#404)
8bc604d 
* Each goroutine must call wg.Done() otherwise wg.Wait() forever
@redouan-rhazouani redouan-rhazouani mentioned this pull request Feb 19, 2022
Closed
0x2b3bfa0
0x2b3bfa0 approved these changes Feb 20, 2022
View reviewed changes
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 Thank you very much!

cml/clone-amis.go Show resolved Hide resolved
@0x2b3bfa0 0x2b3bfa0 merged commit 4fc3ee9 into iterative:master Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@redouan-rhazouani @0x2b3bfa0